sergey/hosts
1
0
Fork 0
mirror of https://github.com/StevenBlack/hosts.git synced 2026-07-01 02:36:52 +00:00
Code Issues Packages Projects Releases Wiki Activity

Improved tests for get_file_by_url

Browse Source
This commit is contained in:
Alexander Cecile
2020-09-02 20:25:01 -04:00
parent d85c96576a
commit b350c68540
1 changed files with 6 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
testUpdateHostsFile.py
View File

@@ -1572,15 +1572,17 @@ class GetFileByUrl(BaseStdout):
self.assertEqual(expected, actual) self.assertEqual(expected, actual)
def test_connect_unknown_domain(self): def test_connect_unknown_domain(self):
test_url = "http://doesnotexist.google.com" test_url = "http://doesnotexist.google.com" # leads to exception: ConnectionError
return_value = get_file_by_url(test_url) with mock.patch("requests.get", side_effect=requests.exceptions.ConnectionError):
return_value = get_file_by_url(test_url)
self.assertIsNone(return_value) self.assertIsNone(return_value)
printed_output = sys.stdout.getvalue() printed_output = sys.stdout.getvalue()
self.assertEqual(printed_output, "Error retrieving data from {}\n".format(test_url)) self.assertEqual(printed_output, "Error retrieving data from {}\n".format(test_url))
def test_invalid_url(self): def test_invalid_url(self):
test_url = "http://fe80::5054:ff:fe5a:fc0" test_url = "http://fe80::5054:ff:fe5a:fc0" # leads to exception: InvalidURL
return_value = get_file_by_url(test_url) with mock.patch("requests.get", side_effect=requests.exceptions.ConnectionError):
return_value = get_file_by_url(test_url)
self.assertIsNone(return_value) self.assertIsNone(return_value)
printed_output = sys.stdout.getvalue() printed_output = sys.stdout.getvalue()
self.assertEqual(printed_output, "Error retrieving data from {}\n".format(test_url)) self.assertEqual(printed_output, "Error retrieving data from {}\n".format(test_url))