From ad356812442c5a49b836c84f3a6fe39ce357bb85 Mon Sep 17 00:00:00 2001 From: Alexander Cecile <35971201+AlexanderCecile@users.noreply.github.com> Date: Fri, 28 Aug 2020 03:17:06 -0400 Subject: [PATCH] Improve tests for get_file_by_url --- testUpdateHostsFile.py | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/testUpdateHostsFile.py b/testUpdateHostsFile.py index 3d80691f3..3f09e2308 100644 --- a/testUpdateHostsFile.py +++ b/testUpdateHostsFile.py @@ -1642,6 +1642,20 @@ class GetFileByUrl(BaseStdout): self.assertEqual(expected, actual) + def test_connect_unknown_domain(self): + test_url = "http://doesnotexist.google.com" + return_value = get_file_by_url(test_url) + self.assertIsNone(return_value) + printed_output = sys.stdout.getvalue() + self.assertEqual(printed_output, "Error retrieving data from {}\n".format(test_url)) + + def test_invalid_url(self): + test_url = "http://fe80::5054:ff:fe5a:fc0" + return_value = get_file_by_url(test_url) + self.assertIsNone(return_value) + printed_output = sys.stdout.getvalue() + self.assertEqual(printed_output, "Error retrieving data from {}\n".format(test_url)) + class TestWriteData(Base): def test_write_basic(self):