'suffix' in regex matches empty string on all the data files, except

one (incorrect) line containing port:
0.0.0.0 telemetry.appex.bing.net:443
The resulting entry in hosts file generated like this:
0.0.0.0 telemetry.appex.bing.net :443
which is incorrect. The bug was not spotted only because the incorrect
line in the data source was after the correct line without port,
thus it was ignored and not added to resulting hosts file.
This commit is contained in:
qqo
2015-10-24 01:43:18 +03:00
parent d810d25178
commit 10c4449774

View File

@@ -189,7 +189,11 @@ def normalizeRule(rule):
if result:
target, hostname, suffix = result.groups()
hostname = hostname.lower() # explicitly lowercase hostname
return hostname, "%s %s %s\n" % (TARGET_HOST, hostname, suffix)
if suffix is not '':
# add suffix as comment only, not as a separate host
return hostname, "%s %s #%s\n" % (TARGET_HOST, hostname, suffix)
else:
return hostname, "%s %s\n" % (TARGET_HOST, hostname)
print '==>%s<==' % rule
return None, None